Adds more columns in revision get command output #70

navidshaikh · 2019-04-12T07:10:07Z

Added few columns in the output as below

kn revision list
NAME       SERVICE   AGE   TRAFFIC
s1-ftc7f   s1        21h   100% -> s1.default.example.com
s2-8pb69   s2        21h   100% -> s2.default.example.com

navidshaikh · 2019-04-12T07:10:37Z

This PR is rebased onto #56 , so that PR #56 should go in first.

cppforlife · 2019-04-15T17:58:21Z

/ok-to-test

knative-prow-robot · 2019-04-15T17:59:29Z

@navidshaikh: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-knative-client-go-coverage	`752d386`	link	`/test pull-knative-client-go-coverage`
pull-knative-client-integration-tests	`752d386`	link	`/test pull-knative-client-integration-tests`
pull-knative-client-build-tests	`752d386`	link	`/test pull-knative-client-build-tests`
pull-knative-client-unit-tests	`752d386`	link	`/test pull-knative-client-unit-tests`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

cppforlife · 2019-04-15T18:03:42Z

pkg/kn/commands/revision_list_test.go

+}
+
+func TestRevisionListDefaultOutput(t *testing.T) {
+	foo_label := make(map[string]string)


some more camel casing needed.

cppforlife · 2019-04-15T18:04:13Z

pkg/kn/commands/revision_list_test.go

+		t.Fatal(err)
+	}
+	// each line's tab/spaces are replaced by comma
+	expected := []string{"NAME,SERVICE,AGE,TRAFFIC",


is there a test with multiple routes for one revision?

@cppforlife: updated tests to reflect same

cppforlife · 2019-04-15T18:05:32Z

pkg/serving/constants.go

+	GroupName = "serving.knative.dev"
+
+	//ConfigurationLabelKey indicates the Configuration revision is created from.
+	ConfigurationLabelKey = GroupName + "/service"


is this something we can pull in from client package instead of duplicating here?

knative-prow-robot · 2019-04-24T18:00:15Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: navidshaikh
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sixolet

If they are not already assigned, you can assign the PR to them by writing /assign @sixolet in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This commit adds basic details about service in service list command output. text/tabwriter is used to print columns on stdout. Fixes #knative#40

This commit adds AGE column representing the resources' age in human readable format calculated from CreationTimestamp field of service.

Now if list is empty, we print "No resources found." string. This commit updates the respective unit test.

Doesn't check the argument length after `service get` to leave room for filtering based on argument.

Fixes knative#41 Adds Name, Service, Age and Traffic column in the revision list output.

also updates the invocation to CalculateAge utility

navidshaikh · 2019-05-03T10:59:40Z

Closing the PR in favor of PR #90

navidshaikh · 2019-05-09T11:06:51Z

Closing in favor of #97

knative-prow-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 12, 2019

knative-prow-robot requested review from mattmoor and sixolet April 12, 2019 07:10

knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 12, 2019

navidshaikh force-pushed the fix-41 branch 3 times, most recently from 2970e9f to edacc08 Compare April 15, 2019 10:36

knative-prow-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 15, 2019

cppforlife reviewed Apr 15, 2019

View reviewed changes

navidshaikh force-pushed the fix-41 branch from 752d386 to 2e5e090 Compare April 24, 2019 17:59

navidshaikh changed the title ~~Adds more columns in revision list command output~~ Adds more columns in revision get command output Apr 24, 2019

navidshaikh added 13 commits May 1, 2019 16:53

Adds more columns in service list command output

294a884

This commit adds basic details about service in service list command output. text/tabwriter is used to print columns on stdout. Fixes #knative#40

Adds AGE column in serivce list command output

2827b7d

This commit adds AGE column representing the resources' age in human readable format calculated from CreationTimestamp field of service.

Updates TestListEmpty test for expected output

4a4a96f

Now if list is empty, we print "No resources found." string. This commit updates the respective unit test.

Updates unit tests for service list command

d15a64f

Adds vendor/k8s.io/apimachinery/pkg/util/duration/duration.go

9d98a55

Returns nil after printing the service list table

0a6ae83

Uses camel case variable names

0e9011d

Removes unused variables

da886c8

Updates the method name and uses defer to flush the printer

8973a25

Moves calculate age utility from util/printers to util/

e2996e0

Adds a switch to enable generic output format flags

4524a7d

Adds test for jsonpath output flag

71c75c9

Renames service list command to service get

9743273

Doesn't check the argument length after `service get` to leave room for filtering based on argument.

navidshaikh added 12 commits May 1, 2019 16:53

Fixes tests

5ecb716

Updates the tests

c9b0e56

Adds more columns in revision list command output

7d9f459

Fixes knative#41 Adds Name, Service, Age and Traffic column in the revision list output.

Adds unit tests for revision list command

dcd5536

Uses defer for flushing the printer

b1f8a1b

also updates the invocation to CalculateAge utility

Uses NewTabWriter instead of GetNewTabWriter

c09e603

Uses camel casing for var names

cf6a788

Renames revision list command to revision get

8ed576b

Restores multiple output format flags from genericclioptions

63d387a

Uses the constants from serving package

849a71b

Updates tests to for multiple routes to single revision

c4a66e3

Adds conditions and ready column

8a1bf15

navidshaikh force-pushed the fix-41 branch from 2e5e090 to 8a1bf15 Compare May 1, 2019 11:34

knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 1, 2019

navidshaikh closed this May 3, 2019

navidshaikh reopened this May 9, 2019

navidshaikh closed this May 9, 2019

navidshaikh deleted the fix-41 branch November 18, 2019 12:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds more columns in revision get command output #70

Adds more columns in revision get command output #70

navidshaikh commented Apr 12, 2019

navidshaikh commented Apr 12, 2019

cppforlife commented Apr 15, 2019

knative-prow-robot commented Apr 15, 2019

cppforlife Apr 15, 2019

navidshaikh Apr 24, 2019

cppforlife Apr 15, 2019

navidshaikh Apr 24, 2019

cppforlife Apr 15, 2019

navidshaikh Apr 24, 2019

knative-prow-robot commented Apr 24, 2019

navidshaikh commented May 3, 2019

navidshaikh commented May 9, 2019

Adds more columns in revision get command output #70

Adds more columns in revision get command output #70

Conversation

navidshaikh commented Apr 12, 2019

navidshaikh commented Apr 12, 2019

cppforlife commented Apr 15, 2019

knative-prow-robot commented Apr 15, 2019

cppforlife Apr 15, 2019

Choose a reason for hiding this comment

navidshaikh Apr 24, 2019

Choose a reason for hiding this comment

cppforlife Apr 15, 2019

Choose a reason for hiding this comment

navidshaikh Apr 24, 2019

Choose a reason for hiding this comment

cppforlife Apr 15, 2019

Choose a reason for hiding this comment

navidshaikh Apr 24, 2019

Choose a reason for hiding this comment

knative-prow-robot commented Apr 24, 2019

navidshaikh commented May 3, 2019

navidshaikh commented May 9, 2019